specconv: avoid skipping gidmappings applied when uidmappings is empty#1665
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Dec 11, 2017
Merged
Conversation
Mashimiao
force-pushed
the
gidmapping-valid-fix
branch
from
f626891 to
57edfbb
Compare
Mashimiao
changed the title
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Contributor
|
This sounds like the cause of this validation failure. |
Author
|
Yes, it is. |
Member
|
LGTM |
Member
|
@mrunalp pullapprove is not registering your lgtm |
Contributor
|
LGTM |
Contributor
|
@crosbymichael Fixed. I think it doesn't like the lgtm from code review submit form. |
Contributor
|
On Mon, Dec 11, 2017 at 05:50:48PM +0000, Mrunal Patel wrote:
I think it doesn't like the lgtm from code review submit form.
That's because runc is still using a v1 PullApprove config [1]. If
you want to count GitHub approvals, you need to migrate to v2
(e.g. opencontainers/project-template#29,
opencontainers/runtime-spec#902).
[1]: https://github.com/opencontainers/runc/blob/c6e4a1ebeb1a72b529c6f1b6ee2b1ae5b868b14f/.pullapprove.yml
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com